Skip to content

GitLab

Open
Created by Ecklory@rootOwner1 of 4 tasks completed1/4 tasks

WIP: PVS-Studio. Fixes (High + General)

  • 1. V603 The object was created but it is not being used. If you wish to call constructor, 'this->CCareerTask::CCareerTask(....)' should be used. career_tasks.cpp 17

See: https://www.viva64.com/en/w/v603/print/

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/career_tasks.cpp#L17

Fix: https://git.ckcorp.ru/ck/game-dev/regamedll_cs/merge_requests/3

  • 2. V547 Expression 'fieldType != CLASSNAME' is always false. cbase.cpp 119 and 197

See: https://www.viva64.com/en/w/v547/print/

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/cbase.cpp#L119

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/cbase.cpp#L119

  • 3. V595 The 'm_pController' pointer was utilized before it was verified against nullptr. Check lines: 298, 300. func_tank.cpp 298 and 300

See: https://www.viva64.com/en/w/v595/print/

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/func_tank.cpp#L298

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/func_tank.cpp#L298

  • 4. V730 Not all members of a class are initialized inside the constructor. Consider inspecting: m_fTargetEntHit, m_nindexAvailableNode. hostage_localnav.cpp 43

See: https://www.viva64.com/en/w/v730/print/

https://git.ckcorp.ru/ck/game-dev/regamedll_cse/blob/f3381e110dd88b362f110920edf218382b60ac52/regamedll/dlls/hostage/hostage_localnav.cpp#L43

Edited by Ecklory